Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing differential rotation of coordinates again. #3123

Merged
merged 13 commits into from May 22, 2019

Conversation

Projects
None yet
4 participants
@wafels
Copy link
Member

commented May 22, 2019

Description

Fixes the differential rotation of coordinates again. With this PR, the solar_rotate_coordinate function returns a coordinate that accounts for the location of the new_observer.

Fixes #

@pep8speaks

This comment has been minimized.

Copy link

commented May 22, 2019

Hello @wafels! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 224:101: E501 line too long (198 > 100 characters)
Line 229:101: E501 line too long (198 > 100 characters)

Comment last updated at 2019-05-22 15:32:39 UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented May 22, 2019

Thanks for the pull request @wafels! Everything looks great!

wafels added some commits May 22, 2019

wafels
wafels

@nabobalis nabobalis added this to the 1.0 milestone May 22, 2019

@Cadair
Copy link
Member

left a comment

Looks generally fine to me but the doctests need fixing.

heliographic_rotated = SkyCoord(heliographic_coordinate.lon + drot,
heliographic_coordinate.lat,
heliographic_coordinate.radius,
obstime = new_observer.obstime,

This comment has been minimized.

Copy link
@Cadair

Cadair May 22, 2019

Member

no spaces around kwarg = please.

@Cadair

Cadair approved these changes May 22, 2019

@Cadair Cadair added the [BugFix] label May 22, 2019

@Cadair Cadair merged commit c77ad4c into sunpy:master May 22, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90.07%)
Details
codecov/project 90.07% (+0%) compared to 80c2e97
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190522.17 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details
@Cadair

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@nabobalis backport please.

@wafels

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

This and the warping code in #2972 can be used to reproject images to different viewpoints.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Can I just protest about the history?

nabobalis added a commit to nabobalis/sunpy that referenced this pull request May 22, 2019

Merge pull request sunpy#3123 from wafels/fixdrot
Fixing differential rotation of coordinates again.
@Cadair

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Me thinks we might have to give @wafels a lesson on rewriting git history 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.