Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rotation arguments to the header helper function #3139

Merged
merged 5 commits into from May 28, 2019

Conversation

Projects
4 participants
@hayesla
Copy link
Contributor

commented May 27, 2019

Description

This is a first pass to include the ability to add the rotation information into the map header helper function #3083 following #3126.

At the moment it's just a patch job which now includes extra keyword arguments for rotation_angle (in u.deg) and then either a rotation_matrix_pc and rotation_matrix_cd for PCi_j and CDi_j rotation matrix. There's probably a nicer way to do this - any ideas?

@pep8speaks

This comment has been minimized.

Copy link

commented May 27, 2019

Hello @hayesla! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-28 21:33:04 UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented May 27, 2019

Thanks for the pull request @hayesla! Everything looks great!

Show resolved Hide resolved sunpy/map/header_helper.py Outdated
Show resolved Hide resolved sunpy/map/header_helper.py Outdated
Show resolved Hide resolved sunpy/map/header_helper.py Outdated
Show resolved Hide resolved sunpy/map/header_helper.py Outdated

@Cadair Cadair added this to the 1.0 milestone May 27, 2019

@Cadair Cadair added this to Post-Feature Freeze in SunPy 1.0 May 27, 2019

Show resolved Hide resolved sunpy/map/header_helper.py Outdated
Show resolved Hide resolved changelog/3139.bugfix.rst Outdated
@Cadair

Cadair approved these changes May 28, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Online test failure is ValueError: No online HELIO servers can be found.

@nabobalis nabobalis merged commit 6164e11 into sunpy:master May 28, 2019

6 of 13 checks passed

sunpy.sunpy Build #20190528.22 had test failures
Details
sunpy.sunpy (Linux_37_online) Linux_37_online failed
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline failed
Details
ci/circleci: 32bit CircleCI is running your tests
Details
ci/circleci: figure-tests-36 CircleCI is running your tests
Details
ci/circleci: html-docs CircleCI is running your tests
Details
ci/circleci: pip-install CircleCI is running your tests
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Thanks @hayesla!

nabobalis added a commit to nabobalis/sunpy that referenced this pull request May 28, 2019

Merge pull request sunpy#3139 from hayesla/helper_map_function
Adding rotation arguments to the header helper function
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Backported.

@Cadair Cadair moved this from Post-Feature Freeze to Finished in SunPy 1.0 May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.