Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up of the install/bug docs #3147

Merged
merged 2 commits into from May 29, 2019

Conversation

Projects
2 participants
@nabobalis
Copy link
Contributor

commented May 29, 2019

I looked over the install and reporting bug part of the guide.

@nabobalis nabobalis added the [DocFix] label May 29, 2019

@nabobalis nabobalis added this to the 1.0 milestone May 29, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented May 29, 2019

Thanks for the pull request @nabobalis! Everything looks great!

@sunpy sunpy deleted a comment from sunpy-bot bot May 29, 2019

@sunpy sunpy deleted a comment from sunpy-bot bot May 29, 2019

@Cadair

Cadair approved these changes May 29, 2019

@Cadair Cadair added this to Post-Feature Freeze in SunPy 1.0 May 29, 2019

@nabobalis nabobalis force-pushed the nabobalis:install_docs branch 2 times, most recently from fe703ab to f7fc1fc May 29, 2019

@nabobalis nabobalis force-pushed the nabobalis:install_docs branch from f7fc1fc to 0a9ca21 May 29, 2019

@nabobalis nabobalis merged commit c597795 into sunpy:master May 29, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a7d2b9e...0a9ca21
Details
codecov/project 90.3% remains the same compared to a7d2b9e
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190529.6 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details
@nabobalis

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

To be backported.

@nabobalis nabobalis deleted the nabobalis:install_docs branch May 29, 2019

@Cadair Cadair moved this from Post-Feature Freeze to Finished in SunPy 1.0 May 29, 2019

nabobalis added a commit to nabobalis/sunpy that referenced this pull request May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.