Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the helioviewer data_sources function #3162

Merged
merged 4 commits into from May 30, 2019

Conversation

Projects
None yet
2 participants
@Cadair
Copy link
Member

commented May 30, 2019

fixes #3159

nabobalis and others added some commits May 30, 2019

@Cadair Cadair requested a review from nabobalis May 30, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented May 30, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair added this to the 1.0 milestone May 30, 2019

@Cadair

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Unrelated online test fails.

@Cadair Cadair merged commit 69755cd into sunpy:master May 30, 2019

14 of 16 checks passed

sunpy.sunpy Build #20190530.29 had test failures
Details
sunpy.sunpy (Linux_37_online) Linux_37_online failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 79.69%)
Details
codecov/project 89.36% (+9.67%) compared to 8a1439b
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@Cadair Cadair deleted the Cadair:fix_helioviewer branch May 30, 2019

Cadair added a commit to nabobalis/sunpy that referenced this pull request May 30, 2019

Merge pull request sunpy#3162 from Cadair/fix_helioviewer
Fix the helioviewer data_sources function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.