Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Carrington longitude and Carrington rotation number #3178

Merged
merged 5 commits into from Jun 6, 2019

Conversation

Projects
None yet
4 participants
@ayshih
Copy link
Contributor

commented Jun 2, 2019

Welp, I didn't quite manage to get this fix into 1.0, but now it's done! The calculations of Carrington longitude and Carrington rotation number have been fixed to use modern definitions, and the outputs match the Astronomical Almanac. If there are discrepancies with other sources (e.g., SSW), it's likely those other sources are doing it wrong.

Closes #2224 and closes #1646

@ayshih ayshih added the coordinates label Jun 2, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented Jun 2, 2019

Hello @ayshih! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-03 04:40:10 UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Jun 2, 2019

Thanks for the pull request @ayshih! Everything looks great!

@ayshih ayshih referenced this pull request Jun 2, 2019

Closed

Carrington rotation number #1646

@nabobalis nabobalis added this to the 1.0.1 milestone Jun 2, 2019

@nabobalis nabobalis added the [BugFix] label Jun 2, 2019

@ayshih

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

I don't understand why the CI is failing, and I can't reproduce it locally. Help?

@nabobalis nabobalis requested a review from Cadair Jun 3, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Restarted the CI, it seems to pass now.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Online failure due to missing database package that should be part of the standard library. I think we can ignore.

@Cadair

Cadair approved these changes Jun 6, 2019

@Cadair Cadair merged commit b1e27cf into sunpy:master Jun 6, 2019

14 of 16 checks passed

sunpy.sunpy Build #20190603.2 had test failures
Details
sunpy.sunpy (Linux_37_online) Linux_37_online failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90.33%)
Details
codecov/project 90.34% (+<.01%) compared to ca7ad00
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@ayshih ayshih deleted the ayshih:carr branch Jun 7, 2019

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Jun 7, 2019

Merge pull request sunpy#3178 from ayshih/carr
Fixed Carrington longitude and Carrington rotation number

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Jun 7, 2019

Merge pull request sunpy#3178 from ayshih/carr
Fixed Carrington longitude and Carrington rotation number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.