Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates to the Gallery #3181

Merged
merged 13 commits into from Jun 7, 2019

Conversation

Projects
None yet
5 participants
@ehsteve
Copy link
Member

commented Jun 3, 2019

Description

This pull request adds a number of new examples to the gallery.

  • Venus transit
  • STEREO SECCHI COR2 star field
  • Planet locations
  • Observer location example

It also makes a few other small fixes.

Fixes #

@ehsteve ehsteve requested a review from nabobalis Jun 3, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Jun 3, 2019

Thanks for the pull request @ehsteve! Everything looks great!

@pep8speaks

This comment has been minimized.

Copy link

commented Jun 3, 2019

Hello @ehsteve! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:101: E501 line too long (101 > 100 characters)

Line 33:101: E501 line too long (107 > 100 characters)
Line 45:101: E501 line too long (102 > 100 characters)
Line 50:101: E501 line too long (108 > 100 characters)
Line 69:101: E501 line too long (101 > 100 characters)
Line 74:101: E501 line too long (104 > 100 characters)

Line 41:101: E501 line too long (102 > 100 characters)
Line 44:14: E231 missing whitespace after ','
Line 44:18: E231 missing whitespace after ','

Line 7:101: E501 line too long (149 > 100 characters)
Line 20:101: E501 line too long (107 > 100 characters)

Line 21:101: E501 line too long (114 > 100 characters)

Comment last updated at 2019-06-07 18:10:56 UTC

@nabobalis nabobalis added the [DocFix] label Jun 3, 2019

@nabobalis nabobalis added this to the 1.0.1 milestone Jun 3, 2019

@nabobalis nabobalis force-pushed the ehsteve:gallery-more branch from d5a8793 to ff544a1 Jun 7, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Rebased and address all bar one of stuarts and alberts comments.

@nabobalis nabobalis removed the [WIP] label Jun 7, 2019

@nabobalis nabobalis force-pushed the ehsteve:gallery-more branch from 0af5af1 to 15c248d Jun 7, 2019

Changed to envtmpdir
This might break.

@nabobalis nabobalis referenced this pull request Jun 7, 2019

Merged

[1.0] v1.0.1 #3195

4 of 4 tasks complete
@Cadair

Cadair approved these changes Jun 7, 2019

Copy link
Member

left a comment

I am happy, but @ayshih 's comment about the coordinate transforms needs resolving.

@ehsteve

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

FYI, @nabobalis @Cadair I addressed @ayshih comment in my latest commit.

@Cadair

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

This needs squash merging.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Yes. I will do so.

@nabobalis nabobalis force-pushed the ehsteve:gallery-more branch from 0e6b472 to 9b78953 Jun 7, 2019

its ok now

@nabobalis nabobalis merged commit d3a81f7 into sunpy:master Jun 7, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90.35%)
Details
codecov/project 90.35% (+0%) compared to 6e4dae2
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190607.33 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_online) Linux_36_online succeeded
Details
sunpy.sunpy (Linux_37_offline) Linux_37_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Thanks again @ehsteve, @ayshih and @Cadair

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.