Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing HGC<->HGC loopback transformation #3186

Merged
merged 4 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@ayshih
Copy link
Contributor

commented Jun 4, 2019

Yes, my objective here is to fix the one missing arrow in our transformation graph. I don't think people are rushing out to use this transformation.

@ayshih ayshih requested a review from Cadair Jun 4, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Jun 4, 2019

Thanks for the pull request @ayshih! Everything looks great!

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Will we want a test for this?

@ayshih

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Good point, added tests

@sunpy sunpy deleted a comment from sunpy-bot bot Jun 6, 2019

@sunpy sunpy deleted a comment from sunpy-bot bot Jun 6, 2019

@Cadair

Cadair approved these changes Jun 6, 2019

@Cadair Cadair merged commit 2dd59b6 into sunpy:master Jun 6, 2019

10 of 14 checks passed

sunpy.sunpy Build #20190606.13 had test failures
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline failed
Details
sunpy.sunpy (Linux_37_online) Linux_37_online failed
Details
sunpy.sunpy (macOS_37_offline)
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details

@ayshih ayshih deleted the ayshih:loopback branch Jun 7, 2019

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Jun 7, 2019

Merge pull request sunpy#3186 from ayshih/loopback
Added missing HGC<->HGC loopback transformation

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Jun 7, 2019

Merge pull request sunpy#3186 from ayshih/loopback
Added missing HGC<->HGC loopback transformation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.