Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contains_coordinate #5252

Merged
merged 6 commits into from Apr 25, 2021
Merged

Add contains_coordinate #5252

merged 6 commits into from Apr 25, 2021

Conversation

dstansby
Copy link
Member

Fixes #4726. This is a tidy and update of #4761.

@dstansby dstansby added map Affects the map submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Apr 24, 2021
@dstansby dstansby added this to the 3.0 milestone Apr 24, 2021
@dstansby dstansby requested a review from a team as a code owner April 24, 2021 19:18
@pep8speaks
Copy link

pep8speaks commented Apr 24, 2021 •
edited

Hello @dstansby! Thanks for updating this PR.

Line 291:101: E501 line too long (107 > 100 characters)
Line 203:101: E501 line too long (106 > 100 characters)

Line 211:101: E501 line too long (108 > 100 characters)
Line 210:101: E501 line too long (114 > 100 characters)
Line 202:101: E501 line too long (113 > 100 characters)
Line 161:101: E501 line too long (109 > 100 characters)
Line 58:101: E501 line too long (110 > 100 characters)

Comment last updated at 2021-04-24 19:41:26 UTC

@dstansby dstansby mentioned this pull request Apr 24, 2021
Closed
@nabobalis nabobalis added this to In progress (Blockers) in SunPy 3.0 via automation Apr 24, 2021
@nabobalis nabobalis moved this from In progress (Blockers) to Needs Review in SunPy 3.0 Apr 24, 2021
nabobalis
nabobalis reviewed Apr 24, 2021
View reviewed changes
sunpy/map/maputils.py Outdated Show resolved Hide resolved
@nabobalis nabobalis merged commit 9e3a51a into sunpy:master Apr 25, 2021
SunPy 3.0 automation moved this from Needs Review to Done Apr 25, 2021
@dstansby dstansby deleted the contains-coord branch April 25, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
map Affects the map submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
No open projects
SunPy 3.0
  
Done
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Add a contains coordinate method to maputils
4 participants
@dstansby @pep8speaks @nabobalis @SnehVachhani