Fixed bug that prevents RotatedSunFrame instances from being pickled #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EdBehn, thanks for the PR! A few comments would be that, like the astropy pull request will want a unit test and a bugfix changelog entry (they go here https://github.com/sunpy/sunpy/tree/main/changelog). |
ayshih
changed the title
|
I'm converting this PR to draft since it can't be reviewed without a unit test |
|
Hi @EdBehn thanks for opening this PR! Do you think you'll be able to add a unit test to this? Let us know if you need any help! If you don't have time to do that, let us know and someone else can finish off the PR. |
|
@dstansby I would need some help writing a unit test as I've never done it before. |
|
The unit test I suggested here should work fine. It needs to be added to the bottom of |
nabobalis
approved these changes
Nov 4, 2022
Addressed sunpy#6279 This fix is based on astropy/astropy#13305 This fix makes it so that RotatedSunFrame objects can be pickled and unpickled. Added unit test and changelog entry
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Nov 4, 2022
…nces from being pickled
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Nov 4, 2022
…nces from being pickled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6279
This fix is based on
astropy/astropy#13305
This fix makes it so that RotatedSunFrame objects
can be pickled and unpickled.