feat(examples): extract shared UI components into examples/shared#86
Merged
Conversation
Consolidates 7 identical components (EntityCard, EntityDetailRows, EntityStateDescription, EligibilityResults, EntitiesList, CommitmentDataCard, NotEligibleMessage) from all four example apps into examples/shared/. Each app now imports via @shared alias, wired through tsconfig paths and Vite resolve.alias. The generate script copies the shared directory alongside each distributed app so standalone builds remain self-contained.
WillSewell
previously approved these changes
May 7, 2026
| { | ||
| // DOLATER: fix eslint violations in framework dirs and remove this ignore | ||
| ignores: ["**/node_modules/**", "**/dist/**", "contracts/**", "examples/framework/**"], | ||
| ignores: ["**/node_modules/**", "**/dist/**", "contracts/**", "examples/framework/**", "examples/shared/**"], |
Contributor
There was a problem hiding this comment.
Would be nice to actually fix this in a follow up while you're touching this
| .join("\n"); | ||
| await writeFile(filePath, cleaned); | ||
| } catch { | ||
| // file may not exist (e.g. Next.js apps have no vite.config.ts) |
Contributor
There was a problem hiding this comment.
could we catch "not exists" errors explicitly here and rethrow any others?
danielrx-echo
force-pushed
the
daniel/sonar-113
branch
from
75df4e2 to
3ab9993
Compare
WillSewell
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/shared/directory@sharedpath alias in each app (tsconfigpaths+ Viteresolve.alias) so imports read@shared/components/...EntitiesListto use its existingsonarFrontendURLprop instead of importingsonarConfigdirectly — removes the only per-app import from that componentgenerate-example.mjsto copyexamples/shared/alongside each distributed app so standalone builds remain self-containedComponents that stay per-app:
AuthenticationSection(server actions vs props pattern differs by framework) andCommitCard(EVM receipt model vs SVM signature model).Closes SONAR-113
Test plan
cd examples/framework/react-evm && pnpm dev— app loads, entity/sale components rendercd examples/framework/react-svm && pnpm dev— samecd examples/framework/nextjs-evm && pnpm dev— samecd examples/framework/nextjs-svm && pnpm dev— samenode examples/scripts/generate-example.mjs react-evm— builds successfully with shared dir copied todist/shared/