Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Solr wouldn't work on Windows. #189

Closed
wants to merge 1 commit into from

2 participants

@munen

Details see commit. It's only a very small fix. Didn't test wheter it works on Unix now.

@alindeman
Owner

Do you know why this is needed? I don't know Windows very well.

@alindeman
Owner

I sidestepped the gsub and tried using Ruby's Shellwords instead. I merged the fix into 1-3-stable and master. Do you have a few minutes to test it out? Thanks

@alindeman alindeman closed this
@munen

It was needed, because the Windows commandline doesn't work with apostrophes, but with double quotes(;

I created this fix while working for a client. I'm not there anymore, so I can't test it unfortunately.

@alindeman
Owner

Roger that. Thanks for responding even so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 27, 2012
  1. @munen
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  sunspot_solr/lib/sunspot/solr/server.rb
View
2  sunspot_solr/lib/sunspot/solr/server.rb
@@ -101,7 +101,7 @@ def run
command << "-Djava.util.logging.config.file=#{logging_config_path}" if logging_config_path
command << '-jar' << File.basename(solr_jar)
FileUtils.cd(File.dirname(solr_jar)) do
- exec(Escape.shell_command(command))
+ exec(Escape.shell_command(command).gsub("'",'"'))
end
end
Something went wrong with that request. Please try again.