From f33da6d5f195767764c0a060ed9b0484449f2dc6 Mon Sep 17 00:00:00 2001 From: Ollie Halliday <22655069+Hallidayo@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:07:32 +0100 Subject: [PATCH 1/2] check for blank email address on magic links --- .../src/components/Auth/interfaces/MagicLink.tsx | 11 +++++++++-- packages/shared/src/types.ts | 1 + 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/Auth/interfaces/MagicLink.tsx b/packages/react/src/components/Auth/interfaces/MagicLink.tsx index a0b047a8..a1537a5d 100644 --- a/packages/react/src/components/Auth/interfaces/MagicLink.tsx +++ b/packages/react/src/components/Auth/interfaces/MagicLink.tsx @@ -36,6 +36,12 @@ function MagicLink({ setError('') setMessage('') setLoading(true) + + if (email.length === 0) { + setError(i18n?.magic_link?.empty_email_address as string) + setLoading(false) + return + } const { error } = await supabaseClient.auth.signInWithOtp({ email, options: { emailRedirectTo: redirectTo }, @@ -60,9 +66,10 @@ function MagicLink({ type="email" autoFocus placeholder={labels?.email_input_placeholder} - onChange={(e: React.ChangeEvent) => + onChange={(e: React.ChangeEvent) => { + if (setError) setError('') setEmail(e.target.value) - } + }} appearance={appearance} /> diff --git a/packages/shared/src/types.ts b/packages/shared/src/types.ts index 7e9ee137..d578b6dd 100644 --- a/packages/shared/src/types.ts +++ b/packages/shared/src/types.ts @@ -137,6 +137,7 @@ export type I18nVariables = { loading_button_label?: string link_text?: string confirmation_text?: string + empty_email_address?: string } forgotten_password?: { email_label?: string From 90465453b2f547c56e0fa8ae1b3b8a1ec1a315db Mon Sep 17 00:00:00 2001 From: Andrew Smith Date: Sun, 17 Sep 2023 12:03:30 +0000 Subject: [PATCH 2/2] Add changeset file to bump the package version --- .changeset/pretty-pumpkins-admire.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/pretty-pumpkins-admire.md diff --git a/.changeset/pretty-pumpkins-admire.md b/.changeset/pretty-pumpkins-admire.md new file mode 100644 index 00000000..dfb23f33 --- /dev/null +++ b/.changeset/pretty-pumpkins-admire.md @@ -0,0 +1,6 @@ +--- +'@supabase/auth-ui-shared': patch +'@supabase/auth-ui-react': patch +--- + +Fix check for blank email address on magic links