From 265267b1fdaf9889b766fe76cee6349855b5f754 Mon Sep 17 00:00:00 2001
From: Zev Averbach <zev@averba.ch>
Date: Mon, 16 Dec 2024 17:35:10 +0100
Subject: [PATCH] avoid building skipped tests vector in every loop

---
 crates/pg_syntax/tests/pg_syntax_tests.rs | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/crates/pg_syntax/tests/pg_syntax_tests.rs b/crates/pg_syntax/tests/pg_syntax_tests.rs
index badbf9da2..ab02915a7 100644
--- a/crates/pg_syntax/tests/pg_syntax_tests.rs
+++ b/crates/pg_syntax/tests/pg_syntax_tests.rs
@@ -15,6 +15,8 @@ const SNAPSHOTS_PATH: &str = "snapshots/data";
 #[test]
 fn valid_statements() {
     // dont do postgres regress tests for now
+    let skipped_tests: Vec<_> = SKIPPED_REGRESS_TESTS.lines().collect();
+
     for path in [VALID_STATEMENTS_PATH] {
         let mut paths: Vec<_> = fs::read_dir(path).unwrap().map(|r| r.unwrap()).collect();
         paths.sort_by_key(|dir| dir.path());
@@ -23,11 +25,7 @@ fn valid_statements() {
             let path = f.path();
             let test_name = path.file_stem().unwrap().to_str().unwrap();
 
-            if SKIPPED_REGRESS_TESTS
-                .lines()
-                .collect::<Vec<_>>()
-                .contains(&test_name)
-            {
+            if skipped_tests.contains(&test_name) {
                 continue;
             }