fix: adjust content-type header in Fetcher.Adapter.Finch.upload/3
#76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load/3` now we check for content-type in the request header before setting it with `MIME.from_path/1`. resolves supabase-community/storage-ex#15
zoedsoupe
approved these changes
Nov 10, 2025
zoedsoupe
approved these changes
Nov 10, 2025
Member
|
thanks! |
Merged
zoedsoupe
added a commit
that referenced
this pull request
Nov 24, 2025
…com:supabase-community/supabase-ex into fix/allow-converting-key-types-json-decoder * 'fix/allow-converting-key-types-json-decoder' of github.com:supabase-community/supabase-ex: fix: adjust content-type header in `Fetcher.Adapter.Finch.upload/3` (#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
when uploading files using Finch adapter, the content-type header in
Requestis always overwritten byMIME.from_path(file)Solution
instead of always setting the content-type header using
MIME.from_path/1, we default to usingRequestheaders, usingMIMEonly as a fallback.resolves supabase-community/storage-ex#15
Rationale
this works without the need to implement adjustments in supabase-community/storage-ex