Fix concurrent calls on Realtime.connect() #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
By introducing a mutex in the Realtime class, we ensure that the
connect()method is never executed concurrently.What is the current behavior?
Bug fix #478. If we call multiple times the
connect()method at the same time, realtime feature can lead to an unpredictable behavior.What is the new behavior?
We ensure that the
connect()method is never executed concurrently.Additional context
I used this documentation to help me choose Mutex as a solution: https://kotlinlang.org/docs/shared-mutable-state-and-concurrency.html#mutual-exclusion
The method
newSingleThreadContextis not available on the common target, soMutexseems to be the best option.