From 69a4f4a6a03ab30ea0c0d9862fa7c15191588f21 Mon Sep 17 00:00:00 2001 From: Lance Mojaver Date: Mon, 15 May 2023 13:29:00 -0700 Subject: [PATCH 1/2] fix url double encode --- gotrue/_async/gotrue_client.py | 3 +-- gotrue/_sync/gotrue_client.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/gotrue/_async/gotrue_client.py b/gotrue/_async/gotrue_client.py index 97f5f14c..8367e9b7 100644 --- a/gotrue/_async/gotrue_client.py +++ b/gotrue/_async/gotrue_client.py @@ -829,8 +829,7 @@ def _get_url_for_provider( provider: Provider, params: Dict[str, str], ) -> str: - params = {k: quote(v) for k, v in params.items()} - params["provider"] = quote(provider) + params["provider"] = provider query = urlencode(params) return f"{self._url}/authorize?{query}" diff --git a/gotrue/_sync/gotrue_client.py b/gotrue/_sync/gotrue_client.py index be893d90..80a9be00 100644 --- a/gotrue/_sync/gotrue_client.py +++ b/gotrue/_sync/gotrue_client.py @@ -827,8 +827,7 @@ def _get_url_for_provider( provider: Provider, params: Dict[str, str], ) -> str: - params = {k: quote(v) for k, v in params.items()} - params["provider"] = quote(provider) + params["provider"] = provider query = urlencode(params) return f"{self._url}/authorize?{query}" From 034da901685a6022e6f16a8588386d54c43b2594 Mon Sep 17 00:00:00 2001 From: Lance Mojaver Date: Tue, 16 May 2023 10:50:55 -0700 Subject: [PATCH 2/2] fix import --- gotrue/_async/gotrue_client.py | 2 +- gotrue/_sync/gotrue_client.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gotrue/_async/gotrue_client.py b/gotrue/_async/gotrue_client.py index 8367e9b7..cbc3de06 100644 --- a/gotrue/_async/gotrue_client.py +++ b/gotrue/_async/gotrue_client.py @@ -3,7 +3,7 @@ from json import loads from time import time from typing import Callable, Dict, List, Tuple, Union -from urllib.parse import parse_qs, quote, urlencode, urlparse +from urllib.parse import parse_qs, urlencode, urlparse from uuid import uuid4 from ..constants import ( diff --git a/gotrue/_sync/gotrue_client.py b/gotrue/_sync/gotrue_client.py index 80a9be00..d2aeefdd 100644 --- a/gotrue/_sync/gotrue_client.py +++ b/gotrue/_sync/gotrue_client.py @@ -3,7 +3,7 @@ from json import loads from time import time from typing import Callable, Dict, List, Tuple, Union -from urllib.parse import parse_qs, quote, urlencode, urlparse +from urllib.parse import parse_qs, urlencode, urlparse from uuid import uuid4 from ..constants import (