Skip to content

fix: validate pooler domain per profile #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

fix: validate pooler domain per profile #4358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0696421
fix: validate pooler domain per profile
sweatybridge Oct 24, 2025
ccfcc92
chore: mark pooler host as optional
sweatybridge Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/utils/connect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func assertDomainInProfile(host string) error {
if err != nil {
return errors.Errorf("failed to parse pooler TLD: %w", err)
}
if !strings.HasSuffix(CurrentProfile.APIURL, "."+domain) {
if len(CurrentProfile.PoolerHost) > 0 && !strings.EqualFold(CurrentProfile.PoolerHost, domain) {
return errors.Errorf("Pooler domain does not belong to current profile: %s", domain)
}
return nil
Expand Down
4 changes: 4 additions & 0 deletions internal/utils/profile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type Profile struct {
APIURL string `mapstructure:"api_url" validate:"required,http_url"`
DashboardURL string `mapstructure:"dashboard_url" validate:"required,http_url"`
ProjectHost string `mapstructure:"project_host" validate:"required,hostname_rfc1123"`
PoolerHost string `mapstructure:"pooler_host" validate:"omitempty,hostname_rfc1123"`
DocsURL string `mapstructure:"docs_url" validate:"omitempty,http_url"`
StudioImage string `mapstructure:"studio_image"`
}
Expand All @@ -26,12 +27,14 @@ var allProfiles = []Profile{{
DashboardURL: "https://supabase.com/dashboard",
DocsURL: "https://supabase.com/docs",
ProjectHost: "supabase.co",
PoolerHost: "supabase.com",
}, {
Name: "supabase-staging",
APIURL: "https://api.supabase.green",
DashboardURL: "https://supabase.green/dashboard",
DocsURL: "https://supabase.com/docs",
ProjectHost: "supabase.red",
PoolerHost: "supabase.green",
}, {
Name: "supabase-local",
APIURL: "http://localhost:8080",
Expand All @@ -44,6 +47,7 @@ var allProfiles = []Profile{{
DashboardURL: "https://cloud.snap.com/dashboard",
DocsURL: "https://cloud.snap.com/docs",
ProjectHost: "snapcloud.dev",
PoolerHost: "snapcloud.co",
}}

var CurrentProfile Profile
Expand Down
Loading