Skip to content

fix(functions): resolve deno lint errors in generated edge function template #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7ttp wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(functions): resolve deno lint errors in generated edge function template #4591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/functions/new/templates/deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{
"imports": {}
"imports": {
"@supabase/functions-js": "jsr:@supabase/functions-js@^2"
}
}
2 changes: 1 addition & 1 deletion internal/functions/new/templates/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This enables autocomplete, go to definition, etc.

// Setup type definitions for built-in Supabase Runtime APIs
import "jsr:@supabase/functions-js/edge-runtime.d.ts"
Copy link
Contributor

@sweatybridge sweatybridge Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyannyacha is this a problem we need to address?

Copy link
Contributor

@nyannyacha nyannyacha Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentioned lints appear to have been introduced in Deno v2.5.
Since we're currently fixed at Deno 2.1.4, not fixing the lints wouldn't cause much impact. However, the problem is that we can't prevent users from using the latest version of Deno.

So in my opinion... yes, I agree to change the template style so the lints don't complain.

import "@supabase/functions-js/edge-runtime.d.ts"

console.log("Hello from Functions!")

Expand Down
Loading