From 6f9a7dc727c3414c6e533934442af2cb93e8279f Mon Sep 17 00:00:00 2001 From: Qiao Han Date: Tue, 21 Mar 2023 16:08:34 +0800 Subject: [PATCH 1/2] fix: log schema diff error --- internal/db/diff/migra.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/db/diff/migra.go b/internal/db/diff/migra.go index 564cf190c..e11bbbc1e 100644 --- a/internal/db/diff/migra.go +++ b/internal/db/diff/migra.go @@ -267,6 +267,9 @@ func DiffSchemaMigra(ctx context.Context, source, target string, schema []string &out, &stderr, ); err != nil { + if stderr.Len() == 0 { + return "", err + } return "", errors.New("error diffing schema:\n" + stderr.String()) } return out.String(), nil From e1141bbc0cee04d221ec02cdf18ce9dfb72936e9 Mon Sep 17 00:00:00 2001 From: Qiao Han Date: Tue, 21 Mar 2023 16:13:37 +0800 Subject: [PATCH 2/2] chore: always print error object --- internal/db/diff/migra.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/internal/db/diff/migra.go b/internal/db/diff/migra.go index e11bbbc1e..d7f73e9db 100644 --- a/internal/db/diff/migra.go +++ b/internal/db/diff/migra.go @@ -267,10 +267,7 @@ func DiffSchemaMigra(ctx context.Context, source, target string, schema []string &out, &stderr, ); err != nil { - if stderr.Len() == 0 { - return "", err - } - return "", errors.New("error diffing schema:\n" + stderr.String()) + return "", fmt.Errorf("error diffing schema: %w:\n%s", err, stderr.String()) } return out.String(), nil }