fix: drop the socket if the worker's http handler returns an invalid value #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laktek
approved these changes
Nov 14, 2025
nyannyacha
deleted the
ny/close-socket-when-return-invalid-value-in-serve-callback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, Enhancement
Description
This PR changes the worker's behavior to immediately drop the socket when the HTTP handler returns anything other than a response object, instead of idling the connection indefinitely (of course, the connection eventually drops anyway when the worker is terminated).
Due to this change, HTTP clients should be able to observe that the socket is immediately dropped in these cases. (In a hyper lib, this is represented by
incomplete_message).