feat(compilation): Implement ARM compilation with ARM runner #426
Conversation
Pull Request Test Coverage Report for Build 19061674830Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
iambriccardo
force-pushed
the
riccardobusetti/feat/arm
branch
from
1f3f9fc to
46ae8e9
Compare
iambriccardo
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| required: false | ||
|
|
||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
The workflow now uploads and downloads build digests via actions/upload-artifact@v4 and actions/download-artifact@v4, but the only explicit permission granted is contents: read. Uploading artifacts requires actions: write (and downloading requires actions: read); with the current permissions the build job will fail with “Resource not accessible by integration” whenever inputs.push is true, preventing the multi‑arch manifest from being created. Please extend the workflow permissions to include the required actions scope.
Useful? React with 👍 / 👎.
etl-api/Dockerfile
Outdated
| ENV SQLX_OFFLINE=true | ||
| RUN cargo build --release -p etl-api && \ | ||
| strip target/release/etl-api | ||
| RUN cargo build --release -p etl-api |
There was a problem hiding this comment.
We are no longer stripping the binary.
etl-replicator/Dockerfile
Outdated
| COPY . . | ||
| RUN RUSTFLAGS="-C panic=abort" cargo build --release -p etl-replicator && \ | ||
| strip target/release/etl-replicator | ||
| RUN cargo build --release -p etl-replicator |
There was a problem hiding this comment.
Missing panic=abort flag & stripping.
This PR fixes broken ARM images for ETL by compiling ARM images on an ARM runner. We chose to avoid cross-compilation to reduce the complexity and make CI faster.