Skip to content

Conversation

@imor
Copy link
Contributor

@imor imor commented Nov 10, 2025

This PR returns a stopping status when the pod is still stopping. Before this PR the pod status returned by the kubectl get pod ... command returned terminating while the api returned the running status.

Companion PR for UI: supabase/supabase#40294

@imor imor marked this pull request as ready for review November 10, 2025 09:36
@imor imor requested a review from a team as a code owner November 10, 2025 09:36
@iambriccardo
Copy link
Contributor

@codex review

Copy link
Contributor

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great quality of life change!

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@imor imor merged commit d8f1327 into main Nov 10, 2025
10 checks passed
@imor imor deleted the rs/add-stopping-status branch November 10, 2025 09:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19226454794

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 32 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 82.367%

Changes Missing Coverage Covered Lines Changed/Added Lines %
etl-api/src/routes/pipelines.rs 0 11 0.0%
etl-api/src/k8s/http.rs 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
etl-api/src/k8s/http.rs 1 90.32%
Totals Coverage Status
Change from base Build 19224853509: -0.05%
Covered Lines: 16120
Relevant Lines: 19571

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Nov 10, 2025

Pull Request Test Coverage Report for Build 19226454794

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 32 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 82.367%

Changes Missing Coverage Covered Lines Changed/Added Lines %
etl-api/src/routes/pipelines.rs 0 11 0.0%
etl-api/src/k8s/http.rs 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
etl-api/src/k8s/http.rs 1 90.32%
Totals Coverage Status
Change from base Build 19224853509: -0.05%
Covered Lines: 16120
Relevant Lines: 19571

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants