Skip to content

Conversation

@iambriccardo
Copy link
Contributor

@iambriccardo iambriccardo commented Dec 5, 2025

This PR fixes a flakiness in env dependent tests for which there was a race condition where tests would interfere with the same environment variables, causing invariants to be violated for individual tests and thus resulting in a failure.

With this fix, we are now locking those tests, this way we guarantee mutual exclusion for the whole execution.

@iambriccardo iambriccardo marked this pull request as ready for review December 5, 2025 08:38
@iambriccardo iambriccardo requested a review from a team as a code owner December 5, 2025 08:38
@coveralls
Copy link

coveralls commented Dec 5, 2025

Pull Request Test Coverage Report for Build 19957305209

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 82.425%

Files with Coverage Reduction New Missed Lines %
etl-postgres/src/tokio/test_utils.rs 4 86.47%
etl/src/replication/client.rs 20 85.55%
Totals Coverage Status
Change from base Build 19929298247: 0.04%
Covered Lines: 16546
Relevant Lines: 20074

💛 - Coveralls

@iambriccardo iambriccardo merged commit 6f741ed into main Dec 5, 2025
11 checks passed
@iambriccardo iambriccardo deleted the fix-flaky branch December 5, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants