feat: add Figma provider #1139
feat: add Figma provider #1139
Conversation
bnjmnt4n
force-pushed
the
providers/figma
branch
from
b3348b9
to
9761d11
Compare
Figma developer reference: https://www.figma.com/developers/api#oauth2
bnjmnt4n
force-pushed
the
providers/figma
branch
from
9761d11
to
4b56473
Compare
|
Wanted to add a suggestion for the provider tests: it would be helpful to have an explicit checklist of things to test for each provider (in CONTRIBUTING.md or elsewhere). My process was to copy the tests from another provider (GitHub in this case), then modify to suit the Figma provider. Since there are lots of differences between each provider (eg. GitHub returns multiple emails whereas Figma only returns one), it's easy to miss out on tests if you're just copying and modifying from another provider's tests (which is what I presume most would do). |
There was a problem hiding this comment.
lgtm - once you've finished adding the docs to https://github.com/supabase/supabase/tree/master/apps/docs/pages/guides/auth/social-login we can merge this one in! let us know if you need any help with that.
|
Oops, forgot to update: made a PR for the docs + adding the Figma provider to the Studio settings at supabase/supabase#15083. Let me know if there's any tweaks required. |
|
@bnjmnt4n yup a checklist does sound good, we actually have plans to refactor the oauth test suite to use gock for mocking the requests and have an interface to clearly define the testing methods that need to be implemented. It's just not high on the priority list since the current tests are already functional. |
|
🎉 This PR is included in version 2.75.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Feature
What is the current behavior?
No provider for Figma.
What is the new behavior?
This PR adds a new provider for Figma.
Additional context
The Figma OAuth2 API only provides a single scope ("file_read"), so there isn't a more restrictive scope solely for getting user metadata.
Figma developer reference: https://www.figma.com/developers/api#oauth2