feat: Ensure postgres conf.d directory is set up #1961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the `/etc/postgresql-custom/conf.d` directory is correctly created and managed by the entrypoint script in Docker images for PostgreSQL 15, 17, and orioledb-17. This change adds logic to `docker-entrypoint.sh` to: - Create the `/etc/postgresql-custom/conf.d` directory if it does not exist. - Set the ownership to `postgres:postgres`. - Set the permissions to `0755`. This ensures that custom PostgreSQL configuration files placed in this directory are correctly recognized and loaded by the PostgreSQL server during container startup, improving configuration management and extension support.
samrose
requested changes
Dec 3, 2025
Collaborator
There was a problem hiding this comment.
So far when I try to build Dockerfile-17 we're seeing
docker build -f Dockerfile-17 -t supabase-postgres-17 .
[+] Building 1.5s (4/4) FINISHED docker:orbstack
=> [internal] load build definition from Dockerfile-17 0.0s
=> => transferring dockerfile: 12.18kB 0.0s
=> resolve image config for docker-image://docker.io/docker/dockerfile:1.6 0.7s
=> [auth] docker/dockerfile:pull token for registry-1.docker.io 0.0s
=> CACHED docker-image://docker.io/docker/dockerfile:1.6@sha256:ac85f380a63b13dfcefa89046420e1781752bab202122f8f50032edf31be0021 0.0s
Dockerfile-17:257
--------------------
256 | RUN sed -i '/03775/a\\
257 | >>> mkdir -p /etc/postgresql-custom/conf.d\
258 | >>> chown postgres:postgres /etc/postgresql-custom/conf.d\
259 | >>> chmod 0755 /etc/postgresql-custom/conf.d' /usr/local/bin/docker-entrypoint.sh
260 |
--------------------
ERROR: failed to build: failed to solve: dockerfile parse error on line 257: unknown instruction: mkdir
the problem is these commands need to be prefixed with RUN
Collaborator
|
Collaborator
|
samrose
reviewed
Dec 3, 2025
- Replaced `nix profile install .#<package>` with `nix profile add path:.#<package>` for installing Nix packages, which is both the recommended command, and allows nix to work with git worktrees when inside Docker. - Ensured the `conf.d` directory for PostgreSQL configuration is correctly copied. - Removed redundant `mkdir` and `chown` commands from the `docker-entrypoint.sh` script, as these are now handled by the `COPY` instruction.
samrose
approved these changes
Dec 4, 2025
yvan-sraka
pushed a commit
that referenced
this pull request
Dec 7, 2025
* feat: Ensure postgres conf.d directory is set up Ensure the `/etc/postgresql-custom/conf.d` directory is correctly created and managed by the entrypoint script in Docker images for PostgreSQL 15, 17, and orioledb-17. This change adds logic to `docker-entrypoint.sh` to: - Create the `/etc/postgresql-custom/conf.d` directory if it does not exist. - Set the ownership to `postgres:postgres`. - Set the permissions to `0755`. This ensures that custom PostgreSQL configuration files placed in this directory are correctly recognized and loaded by the PostgreSQL server during container startup, improving configuration management and extension support. * build: Update Nix install command and Dockerfile configs - Replaced `nix profile install .#<package>` with `nix profile add path:.#<package>` for installing Nix packages, which is both the recommended command, and allows nix to work with git worktrees when inside Docker. - Ensured the `conf.d` directory for PostgreSQL configuration is correctly copied. - Removed redundant `mkdir` and `chown` commands from the `docker-entrypoint.sh` script, as these are now handled by the `COPY` instruction.
yvan-sraka
pushed a commit
that referenced
this pull request
Dec 8, 2025
* feat: Ensure postgres conf.d directory is set up Ensure the `/etc/postgresql-custom/conf.d` directory is correctly created and managed by the entrypoint script in Docker images for PostgreSQL 15, 17, and orioledb-17. This change adds logic to `docker-entrypoint.sh` to: - Create the `/etc/postgresql-custom/conf.d` directory if it does not exist. - Set the ownership to `postgres:postgres`. - Set the permissions to `0755`. This ensures that custom PostgreSQL configuration files placed in this directory are correctly recognized and loaded by the PostgreSQL server during container startup, improving configuration management and extension support. * build: Update Nix install command and Dockerfile configs - Replaced `nix profile install .#<package>` with `nix profile add path:.#<package>` for installing Nix packages, which is both the recommended command, and allows nix to work with git worktrees when inside Docker. - Ensured the `conf.d` directory for PostgreSQL configuration is correctly copied. - Removed redundant `mkdir` and `chown` commands from the `docker-entrypoint.sh` script, as these are now handled by the `COPY` instruction.
yvan-sraka
pushed a commit
that referenced
this pull request
Dec 8, 2025
* feat: Ensure postgres conf.d directory is set up Ensure the `/etc/postgresql-custom/conf.d` directory is correctly created and managed by the entrypoint script in Docker images for PostgreSQL 15, 17, and orioledb-17. This change adds logic to `docker-entrypoint.sh` to: - Create the `/etc/postgresql-custom/conf.d` directory if it does not exist. - Set the ownership to `postgres:postgres`. - Set the permissions to `0755`. This ensures that custom PostgreSQL configuration files placed in this directory are correctly recognized and loaded by the PostgreSQL server during container startup, improving configuration management and extension support. * build: Update Nix install command and Dockerfile configs - Replaced `nix profile install .#<package>` with `nix profile add path:.#<package>` for installing Nix packages, which is both the recommended command, and allows nix to work with git worktrees when inside Docker. - Ensured the `conf.d` directory for PostgreSQL configuration is correctly copied. - Removed redundant `mkdir` and `chown` commands from the `docker-entrypoint.sh` script, as these are now handled by the `COPY` instruction.
yvan-sraka
pushed a commit
that referenced
this pull request
Dec 8, 2025
* feat: Ensure postgres conf.d directory is set up Ensure the `/etc/postgresql-custom/conf.d` directory is correctly created and managed by the entrypoint script in Docker images for PostgreSQL 15, 17, and orioledb-17. This change adds logic to `docker-entrypoint.sh` to: - Create the `/etc/postgresql-custom/conf.d` directory if it does not exist. - Set the ownership to `postgres:postgres`. - Set the permissions to `0755`. This ensures that custom PostgreSQL configuration files placed in this directory are correctly recognized and loaded by the PostgreSQL server during container startup, improving configuration management and extension support. * build: Update Nix install command and Dockerfile configs - Replaced `nix profile install .#<package>` with `nix profile add path:.#<package>` for installing Nix packages, which is both the recommended command, and allows nix to work with git worktrees when inside Docker. - Ensured the `conf.d` directory for PostgreSQL configuration is correctly copied. - Removed redundant `mkdir` and `chown` commands from the `docker-entrypoint.sh` script, as these are now handled by the `COPY` instruction.
yvan-sraka
pushed a commit
that referenced
this pull request
Dec 8, 2025
* feat: Ensure postgres conf.d directory is set up Ensure the `/etc/postgresql-custom/conf.d` directory is correctly created and managed by the entrypoint script in Docker images for PostgreSQL 15, 17, and orioledb-17. This change adds logic to `docker-entrypoint.sh` to: - Create the `/etc/postgresql-custom/conf.d` directory if it does not exist. - Set the ownership to `postgres:postgres`. - Set the permissions to `0755`. This ensures that custom PostgreSQL configuration files placed in this directory are correctly recognized and loaded by the PostgreSQL server during container startup, improving configuration management and extension support. * build: Update Nix install command and Dockerfile configs - Replaced `nix profile install .#<package>` with `nix profile add path:.#<package>` for installing Nix packages, which is both the recommended command, and allows nix to work with git worktrees when inside Docker. - Ensured the `conf.d` directory for PostgreSQL configuration is correctly copied. - Removed redundant `mkdir` and `chown` commands from the `docker-entrypoint.sh` script, as these are now handled by the `COPY` instruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the
/etc/postgresql-custom/conf.ddirectory is correctly created and managed by the entrypoint script in Docker images for PostgreSQL 15, 17, and orioledb-17.This change adds logic to
docker-entrypoint.shto:/etc/postgresql-custom/conf.ddirectory if it does not exist.postgres:postgres.0755.This ensures that custom PostgreSQL configuration files placed in this directory are correctly recognized and loaded by the PostgreSQL server during container startup, improving configuration management and extension support.