Skip to content

chore: validate nix hash and auto correct#1851

Merged
filipecabaco merged 3 commits into
mainfrom
chore/validate-nix-hash
May 7, 2026
Merged

chore: validate nix hash and auto correct#1851
filipecabaco merged 3 commits into
mainfrom
chore/validate-nix-hash

Conversation

@filipecabaco
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

validate nix hash and auto correct

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2026

Coverage Status

Coverage is 91.672%chore/validate-nix-hash into main. No base build found for main.

id: app-token
uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1
with:
app-id: ${{ secrets.GH_AUTOFIX_APP_ID }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this come from GH_AUTOFIX_APP_ID ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are present in our git action secrets

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see the supabase js updater thing

Copy link
Copy Markdown
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small non-blocking suggestions

Comment thread .github/workflows/fix-nix-hash.yml Outdated
with:
ref: ${{ github.head_ref }}
token: ${{ steps.app-token.outputs.token }}
fetch-depth: 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: 1 is already the default value if you want to remove this line

Comment thread .github/workflows/fix-nix-hash.yml Outdated
git config --local user.name "github-actions[bot]"
git config --local user.email "github-actions[bot]@users.noreply.github.com"
git add test/e2e/flake.nix
git commit -m "fix: update nix node_modules hash"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix or chore? is this used in deployments somehow?

nitpick to help identify these PRs:

Suggested change
git commit -m "fix: update nix node_modules hash"
git commit -m "fix: update nix output hash for e2e tests"

@filipecabaco filipecabaco merged commit a27ed57 into main May 7, 2026
9 checks passed
@filipecabaco filipecabaco deleted the chore/validate-nix-hash branch May 7, 2026 14:58
@realtime-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 2.93.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants