fix: provide unique metric identity for workers#1134
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes OpenTelemetry metric writer collisions (notably under Watt when multiple workers share the same hostname) by adding a stable, unique service instance identity to the metric Resource and ensuring it is propagated into Prometheus/remote-write label sets via the example collector config.
Changes:
- Derive a unique
service.instance.idbased on hostname + Platformatic application/worker identity (or PID fallback) and attach it to the OTel Resource. - Expose additional identity/resource attributes (
service.instance.id,worker.id,platformatic.application.id) as constant labels for the Prometheus exporter. - Update the example OTel Collector config (and add tests) to copy these Resource attributes into datapoint attributes/labels (including
service.name).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/internal/monitoring/otel-metrics.ts | Adds unique metric identity (service instance id + worker/app ids) to the OTel Resource and Prometheus constant-label filtering. |
| src/internal/monitoring/otel-metrics.test.ts | Adds coverage for Watt worker identity mapping and verifies collector config contains the new promotion rules. |
| monitoring/otel/config/otel-collector-config.yml | Promotes Resource identity attributes (and service.name) into metric datapoint attributes for stable routing/unique writer labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 26952733055Coverage increased (+0.04%) to 76.346%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
fenos
approved these changes
Jun 4, 2026
fenos
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Under Watt metrics can conflict with same hostname.
What is the new behavior?
Give unique writer identity:
hostname:applicationId:worker:<workerId>hostname:pid:<process.pid>Additional context
Also, add
service.nameinto example collector config, was forgotten in #1112