Skip to content

chore(ci): extract common deps setup#1136

Merged
ferhatelmas merged 1 commit into
masterfrom
ferhat/ci-node-setup
Jun 5, 2026
Merged

chore(ci): extract common deps setup#1136
ferhatelmas merged 1 commit into
masterfrom
ferhat/ci-node-setup

Conversation

@ferhatelmas

@ferhatelmas ferhatelmas commented Jun 5, 2026

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

refactor ci

What is the current behavior?

Node/npm deps setup is repeated.

What is the new behavior?

Extract it to a common composite action.

Additional context

Checkout must be kept separate since common is a local action.
Release keeps its no cache behavior.
Drop useless matrix in docs workflow.

Copilot AI review requested due to automatic review settings June 5, 2026 09:21
@ferhatelmas ferhatelmas requested a review from a team as a code owner June 5, 2026 09:21
@ferhatelmas ferhatelmas changed the title chore(ci): extract common node setup chore(ci): extract common deps setup Jun 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors GitHub Actions CI workflows by extracting the repeated Node/npm setup, npm cache restore, and npm ci install steps into a single local composite action, then updating workflows to use it (while preserving “no cache” behavior for release).

Changes:

  • Added a new composite action (setup-node-dependencies) to restore npm cache (optionally), run existing setup-node-npm, and install dependencies via npm ci.
  • Updated CI, docs, acceptance, and release workflows to replace duplicated cache/setup/install steps with the new composite action.
  • Ensured release can explicitly disable npm caching via an action input.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/release.yml Replaces repeated Node setup/install with the new composite action and disables cache for release.
.github/workflows/docs.yml Switches to the composite action so docs export job no longer repeats cache/setup/install.
.github/workflows/ci.yml Replaces repeated cache/setup/install steps across all CI jobs with the composite action.
.github/workflows/acceptance.yml Uses the composite action for acceptance workflows to remove repeated cache/setup/install.
.github/actions/setup-node-dependencies/action.yml Introduces the shared composite action that centralizes npm cache restore + Node/npm setup + npm ci.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/actions/setup-node-dependencies/action.yml
@coveralls

coveralls commented Jun 5, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27007051749

Coverage decreased (-0.005%) to 76.349%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11021
Covered Lines: 8847
Line Coverage: 80.27%
Relevant Branches: 6458
Covered Branches: 4498
Branch Coverage: 69.65%
Branches in Coverage %: Yes
Coverage Strength: 368.58 hits per line

💛 - Coveralls

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@ferhatelmas ferhatelmas merged commit 6de4140 into master Jun 5, 2026
23 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/ci-node-setup branch June 5, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants