fix: add multigres into acceptance matrix#1137
Merged
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands CI/acceptance coverage by adding Multigres to the local acceptance matrix and adjusting pgvector single-tenant behavior so vector-store migrations/runtime can run without CREATE DATABASE (needed for gateways like Multigres).
Changes:
- Add
VECTOR_DATABASE_CREATEconfig flag to disableCREATE DATABASE storage_vectorsand instead run vector migrations/runtime directly againstVECTOR_DATABASE_URL. - Extend the acceptance workflow matrix to include
multigresand wire the appropriate infra restart + env defaults. - Factor Multigres image pulling into a reusable composite GitHub Action and switch Multigres infra to use the
latestimage tag.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/internal/database/migrations/vector-store-migrations.test.ts |
Adds coverage for single-tenant vector migrations when DB creation is disabled. |
src/internal/database/migrations/migrate.ts |
Threads vectorDatabaseCreate into the vector migration runner in single-tenant mode. |
src/http/plugins/vector.ts |
Aligns runtime pgvector connection target with VECTOR_DATABASE_CREATE. |
src/config.ts |
Introduces vectorDatabaseCreate config parsing from VECTOR_DATABASE_CREATE. |
package.json |
Adds a Multigres+pgvector test script with VECTOR_DATABASE_CREATE=false. |
acceptance/scripts/run-managed-local.ts |
Allows infra:restart:ci:multigres for managed-local acceptance runs. |
acceptance/README.md |
Documents Multigres vector acceptance behavior and the new flag. |
.github/workflows/ci.yml |
Replaces inline Multigres pull logic with the new composite action. |
.github/workflows/acceptance.yml |
Adds Multigres to the acceptance matrix and configures env/restart logic. |
.github/actions/pull-multigres-cluster/action.yml |
New composite action to pull the Multigres image with retries. |
.docker/docker-compose-infra-multigres-override.yml |
Switches Multigres image reference to ghcr.io/multigres/multigres-cluster:latest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 27017816367Coverage increased (+0.07%) to 76.416%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
TylerHillery
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Multigres doesn't have acceptance matrix, only integration.
What is the new behavior?
Multigres is a matrix entry for acceptance tests.
Additional context
Switching multigres image to latest (unlogged table support is reverted and pgvector is already included)
Gateway doesn't support provisioning multiple databases, so single tenant vector tests live in a different schema but not in a different database unlike pg/oriole and it's configured via env defaults to pg/orioledb to create a new database.
Extract multigres pull into a composite action for reuse.
Update instance type since matrix has 12 combinations now.