From b99b1163a5cbb4264ba7a3a206e7df0f922ba2c2 Mon Sep 17 00:00:00 2001 From: dshukertjr Date: Thu, 21 Dec 2023 10:55:27 +0900 Subject: [PATCH 1/2] fix: Passing null to not filter not allowed bug --- .../postgrest/lib/src/postgrest_filter_builder.dart | 2 +- packages/postgrest/test/filter_test.dart | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/postgrest/lib/src/postgrest_filter_builder.dart b/packages/postgrest/lib/src/postgrest_filter_builder.dart index cb4af96d..4511e2a9 100644 --- a/packages/postgrest/lib/src/postgrest_filter_builder.dart +++ b/packages/postgrest/lib/src/postgrest_filter_builder.dart @@ -24,7 +24,7 @@ class PostgrestFilterBuilder extends PostgrestTransformBuilder { /// .select() /// .not('status', 'eq', 'OFFLINE'); /// ``` - PostgrestFilterBuilder not(String column, String operator, Object value) { + PostgrestFilterBuilder not(String column, String operator, Object? value) { final Uri url; if (value is List) { if (operator == "in") { diff --git a/packages/postgrest/test/filter_test.dart b/packages/postgrest/test/filter_test.dart index 915c6648..2ee26242 100644 --- a/packages/postgrest/test/filter_test.dart +++ b/packages/postgrest/test/filter_test.dart @@ -45,6 +45,19 @@ void main() { } }); + test('not with is null', () async { + final res = await postgrest + .from('users') + .select('username') + .not('username', 'is', null); + expect(res.length, 4); + + for (final item in res) { + expect(item['username'] != ('supabot'), true); + expect(item['username'] != ('kiwicopple'), true); + } + }); + test('not with List of values', () async { final res = await postgrest .from('users') From cd3b2f7a7df5922110a8916a08dd38cf03a59a81 Mon Sep 17 00:00:00 2001 From: dshukertjr Date: Thu, 21 Dec 2023 10:56:25 +0900 Subject: [PATCH 2/2] update test --- packages/postgrest/test/filter_test.dart | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/postgrest/test/filter_test.dart b/packages/postgrest/test/filter_test.dart index 2ee26242..606a3ac6 100644 --- a/packages/postgrest/test/filter_test.dart +++ b/packages/postgrest/test/filter_test.dart @@ -51,11 +51,6 @@ void main() { .select('username') .not('username', 'is', null); expect(res.length, 4); - - for (final item in res) { - expect(item['username'] != ('supabot'), true); - expect(item['username'] != ('kiwicopple'), true); - } }); test('not with List of values', () async {