Skip to content

fix: Make sure the package can be built on Flutter web #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2024
Merged

fix: Make sure the package can be built on Flutter web #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22ea442
Add test to build flutter web
dshukertjr Jul 26, 2024
0675dc0
Adjust the path of the ci pipeline
dshukertjr Jul 26, 2024
189fd65
update melos config to include supabase_flutter example and use the l…
dshukertjr Jul 26, 2024
df6ea5c
chore: remove packgaes from bootstrap seection
Vinzent03 Jul 26, 2024
6385aee
ci: run bootstrap in non flutter packages
Vinzent03 Jul 26, 2024
06d4eb5
ci: run supabase_flutter ci on isolate package changes
Vinzent03 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/functions_client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
run: |
cd ../../
dart pub global activate melos
melos bootstrap --ignore="supabase_flutter"
melos bootstrap --no-flutter

- name: dartfmt
if: ${{ matrix.sdk == 'stable'}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gotrue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: |
cd ../../
dart pub global activate melos
melos bootstrap --ignore="supabase_flutter"
melos bootstrap --no-flutter

- name: dartfmt
if: ${{ matrix.sdk == 'stable'}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/postgrest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
run: |
cd ../../
dart pub global activate melos
melos bootstrap --ignore="supabase_flutter"
melos bootstrap --no-flutter

- name: dartfmt
if: ${{ matrix.sdk == 'stable'}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/realtime_client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: |
cd ../../
dart pub global activate melos
melos bootstrap --ignore="supabase_flutter"
melos bootstrap --no-flutter

- name: dartfmt
if: ${{ matrix.sdk == 'stable'}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/storage_client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
run: |
cd ../../
dart pub global activate melos
melos bootstrap --ignore="supabase_flutter"
melos bootstrap --no-flutter

- name: dartfmt
if: ${{ matrix.sdk == 'stable'}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/supabase.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
run: |
cd ../../
dart pub global activate melos
melos bootstrap --ignore="supabase_flutter"
melos bootstrap --no-flutter

- name: dartfmt
if: ${{ matrix.sdk == 'stable'}}
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/supabase_flutter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:
- 'packages/realtime_client/**'
- 'packages/storage_client/**'
- 'packages/supabase/**'
- 'packages/yet_another_json_isolate/**'

pull_request:
paths:
Expand All @@ -24,6 +25,7 @@ on:
- 'packages/realtime_client/**'
- 'packages/storage_client/**'
- 'packages/supabase/**'
- 'packages/yet_another_json_isolate/**'

jobs:
test:
Expand Down Expand Up @@ -76,3 +78,8 @@ jobs:
run: |
flutter pub downgrade app_links
flutter test --concurrency=1

- name: Verify if Flutter web build is successful
run: |
cd example
flutter build web
2 changes: 1 addition & 1 deletion .github/workflows/yet_another_json_isolate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: |
cd ../../
dart pub global activate melos
melos bootstrap --ignore="supabase_flutter"
melos bootstrap --no-flutter

- name: dartfmt
if: ${{ matrix.sdk == 'stable'}}
Expand Down
1 change: 1 addition & 0 deletions melos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ repository: https://github.com/supabase/supabase-flutter

packages:
- packages/*
- packages/supabase_flutter/example

command:
version:
Expand Down
2 changes: 1 addition & 1 deletion packages/yet_another_json_isolate/lib/src/_isolates_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class YAJsonIsolate {
return jsonDecode(json);
}

Future<String> encode(Map json) async {
Future<String> encode(Object? json) async {
await null;
return jsonEncode(json);
}
Expand Down