fix(docs,www): reduce warnings of invalid jsx & mdx attributes #14398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andykenward is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Awesome @andykenward thanks for this! Overdue! |
saltcod
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A few fixes for the docs & www site. Mainly invalid mdx elements for
<svg>,<video>&<source>. Along with a couple next.js warnings.The experimental feature of
mdxRsis enabled indocs. But this isn't doing anything as you don't have the version of@next/mdxthat supports it installed. Version@next/mdx``^13.0.2supports this. Andnext^13.0.2will stop logging a warning ofunexpected property. See the additional context screenshots below.What is the current behavior?
Warnings & errors are logged in terminal and browser console when running docs & www in dev mode.
In some cases a
<video>would notautoPlayorloopwith invalid attributes. See the additional context screenshots below.What is the new behavior?
Fixes should remove some of the warning & errors logs while working in dev mode.
<video>in.mdxfiles that are set toautoPlayandloopshould do so now.Additional context