Skip to content

Conversation

@kishanhitk
Copy link
Contributor

@kishanhitk kishanhitk commented Aug 25, 2023

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Fixes #16821
Also fixes: #16830

What is the new behavior?

Now, the dashboard gives proper error message, if the operation fails.

Additional context

Turns out this was simply a missing await bug.

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 5:58am
studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 5:58am
studio-self-hosted ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 5:58am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 5:58am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 5:58am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2023 5:58am

@vercel
Copy link

vercel bot commented Aug 25, 2023

@kishanhitk is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@kishanhitk kishanhitk marked this pull request as ready for review August 25, 2023 16:01
@kishanhitk kishanhitk requested a review from a team as a code owner August 25, 2023 16:01
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @kishanhitk!

@alaister alaister changed the title fix: Supabase Studio giving success message even if the delete user operation fails fix(local): Supabase Studio giving success message even if the delete user operation fails Aug 28, 2023
@alaister alaister merged commit f6f2e5d into supabase:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Dashboard gets stuck if user deletion fails. bug: Supabase Studio giving success message even if the delete user operation fails

2 participants