feat: add editing support for citext data type in table editor#17666
Merged
ivasilov merged 8 commits intosupabase:masterfrom Sep 29, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@kishanhitk is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
ivasilov
requested changes
Sep 25, 2023
Member
ivasilov
left a comment
ivasilov
left a comment
There was a problem hiding this comment.
hey @kishanhitk, instead of expanding isTextColumn, can you define a new function isCiTextColumn and add in the if-else chain beneath isTextColumn? I think that approach is clearer.
Contributor
Author
|
Thanks @ivasilov, |
ivasilov
approved these changes
Sep 29, 2023
Member
|
@kishanhitk Thank you for your contribution. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
Columns of
citextare not editable, as the current logic assumes it to be an enum.Fixes: #17451
What is the new behavior?
Columns of
citextare treated as text columns, and are editable as text.Additional context