feat: Add native sign in for Kakao with OIDC #25981
Closed
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
feature, docs update
What is the current behavior?
https://github.com/orgs/supabase/discussions/23368
Kakao provides two different keys which are REST API key, and Native app key.
Supabase accept only one key(currently REST API key), so it should accept both keys to provide seamless sign in process in native apps.
What is the new behavior?
A local dev studio doesn't show me a
Provider
section inAuthentication
>Configuration
, but I added a new field for theNative app key
, similar toAuthorized Client IDs
ofGoogle
Also, I add the docs with native app sign in with trying my best to preserve original author's tone.
Additional context
supabase.auth also must be fixed to accept this new value
EXTERNAL_KAKAO_NATIVE_APP_KEY
.(https://github.com/supabase/auth/blob/ed2b4907244281e4c54aaef74b1f4c8a8e3d97c9/internal/api/token_oidc.go#L77)
I'll make a new PR in that repository after this PR is accepted.