Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/studio/logs: Timestamp from dropdown input #4904

Merged
merged 18 commits into from Jan 20, 2022

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented Jan 10, 2022

image

This PR introduces a timestamp from input (in a dropdown, see above)which allows studio users to set or clear the filter.

Clicking on the Now button will open up the dropdown, showing the currrent timestamp.

Upon changing the timestamp value to a valid ISO timestamp and clicking submit, it will trigger the filter and set internal filter state to that value.

Once internal state is set, the LogPanel timestamp button will display as a button group, with Custom on the left and a clear filter button on the right. It will also be highlighted (either solid bg or dash-outlined) to signify that the filter is active.

  • merge in feat/studio/Home: minutely/hourly/daily usage charts #4732 , whcih contains radix dropdown test helpers
  • LogPanel timestamp from button + dropdown
  • add timestamp input
    • user input validation onChange
    • clearable
    • label
  • hide when custom query mode
  • query params handling
    • auto-populate based on ts query param
    • set query param ts value

@vercel
Copy link

vercel bot commented Jan 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

about – ./about

🔍 Inspect: https://vercel.com/supabase/about/9SrnroyGL8VuD5DbU3UDdyskzWPS
✅ Preview: https://about-git-feat-logs-timestamp-from-customization-supabase.vercel.app

[Deployment for 022d54a canceled]

zones-docs – ./web

🔍 Inspect: https://vercel.com/supabase/zones-docs/GEzXhtjzZih2F4uVgXKFmGQ88uYD
✅ Preview: https://zones-docs-git-feat-logs-timestamp-from-customization-supabase.vercel.app

[Deployment for 022d54a canceled]

zone-www-dot-com – ./www

🔍 Inspect: https://vercel.com/supabase/zone-www-dot-com/94YUnaudSuKvmotaFGdhPjw5Zqjo
✅ Preview: https://zone-www-dot-com-git-feat-logs-timestamp-from-c-369396-supabase.vercel.app

[Deployment for 022d54a canceled]

@vercel vercel bot temporarily deployed to Preview – about January 10, 2022 11:29 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 10, 2022 11:29 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 10, 2022 11:29 Inactive
@Ziinc
Copy link
Contributor Author

Ziinc commented Jan 12, 2022

Blocked by #4732 due to dropdown helper and radix setup not present in master yet.

Indirectly blocked by https://github.com/supabase/infrastructure/issues/3560

@vercel vercel bot temporarily deployed to Preview – about January 17, 2022 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 17, 2022 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 17, 2022 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – about January 18, 2022 10:50 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 18, 2022 10:50 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 18, 2022 10:50 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 18, 2022 11:05 Inactive
@vercel vercel bot temporarily deployed to Preview – about January 18, 2022 11:05 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 18, 2022 11:05 Inactive
@vercel vercel bot temporarily deployed to Preview – about January 18, 2022 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 18, 2022 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 18, 2022 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – about January 18, 2022 16:23 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 18, 2022 16:23 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 18, 2022 16:23 Inactive
@Ziinc
Copy link
Contributor Author

Ziinc commented Jan 18, 2022

Latest demo, ready for review

Screen.Recording.2022-01-19.at.12.21.49.AM.mov

I had to hack around with the border radius using tailwind's JIT important ! to get it to look like a button group, since ui lib doesn't have button groups. @MildTomato FYI.

The timestamp input gets hidden when in query mode.

@vercel vercel bot temporarily deployed to Preview – about January 18, 2022 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 18, 2022 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 18, 2022 16:29 Inactive
@Ziinc
Copy link
Contributor Author

Ziinc commented Jan 18, 2022

allowed timestamp range checking and warning info text based on free restrictions vs pro will be added in later PR, once Pro checking on api side is complete

@vercel vercel bot temporarily deployed to Preview – about January 19, 2022 14:52 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 19, 2022 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 19, 2022 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 19, 2022 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – about January 19, 2022 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 19, 2022 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – about January 20, 2022 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 20, 2022 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – zones-docs January 20, 2022 18:19 Inactive
@Ziinc Ziinc enabled auto-merge January 20, 2022 18:19
@Ziinc Ziinc merged commit cc605d5 into master Jan 20, 2022
@Ziinc Ziinc deleted the feat/logs-timestamp-from-customization branch January 20, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants