fix: return error and terminate pool on invalid search path, psql integration tests#860
Merged
Merged
Conversation
- Adds an integration suite that verifies correct behavior of PGOPTIONS parsing and propagation. - Updates CI workflow to ensure the psql client is available for integration runs. - Increases test max_pools to accommodate additional tenants.
Additionally, adapts psql tests for the new behaviour, and removes the log_level test (won't properly work that way).
v0idpwn
changed the title
v0idpwn
commented
Feb 12, 2026
Comment on lines
+340
to
+345
| {:error_response, %{"S" => "FATAL", "C" => "22023"} = error} -> | ||
| Logger.error("DbHandler: Invalid parameter value: #{inspect(error)}") | ||
|
|
||
| {:keep_state_and_data, | ||
| {:next_event, :internal, {:terminate_with_error, error, :shutdown_pool}}} | ||
|
|
Member
Author
There was a problem hiding this comment.
This ensures that we don't enter a retry loop when we have some invalid search path
v0idpwn
commented
Feb 12, 2026
v0idpwn
commented
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on top of #770.
The tests revealed an interesting failure mode: previously, an invalid search path would crash the DbHandler, which would be restarted by the Supervisor and crash loop. This makes it terminate the pool.
Additionally, they revealed that we needed to escape the data again before sending it to the upstream db, which I also do in this PR. While implementing that, I noticed some quirks of pgsql escaping and implemented ours accordingly.