chore(s3vectors): [WRA-10] change custom type embd name to s3vec
#524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to change custom type
embdname tos3vec. We'd prefer to use s3 as a prefix so we can standardise on anything else that the s3 team adds in the future.What is the current behavior?
N/A
What is the new behavior?
N/A
Additional context
This PR also replaced
s3vec::fromwiths3vec::try_fromto guard null pointer.