Skip to content

Conversation

@burmecia
Copy link
Member

What kind of change does this PR introduce?

This PR is to remove bucket_name option from import foreign schema statement.

What is the current behavior?

When importing foreign schema from remote, the bucket name is specified by bucket_name option.

What is the new behavior?

The bucket_name option has been replaced by the remote schema in import foreign schema statement, e.g.

import foreign schema "my-vector-bucket-name"
from server s3_vectors_server into s3_vectors;

Additional context

N/A

Copilot AI review requested due to automatic review settings November 19, 2025 06:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the S3 Vectors FDW by removing the bucket_name option from the IMPORT FOREIGN SCHEMA statement and instead using the PostgreSQL standard remote_schema parameter to specify the bucket name.

Key Changes:

  • Updated the import_foreign_schema implementation to read bucket name from import_stmt.remote_schema instead of parsing it from options
  • Bumped wrapper version from 0.1.1 to 0.1.2
  • Updated all documentation and examples to reflect the new syntax

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
wrappers/src/fdw/s3vectors_fdw/s3vectors_fdw.rs Modified import_foreign_schema to use remote_schema field directly and bumped version to 0.1.2
wrappers/src/fdw/s3vectors_fdw/tests.rs Updated test to use new syntax with bucket name in remote schema parameter
wrappers/src/fdw/s3vectors_fdw/README.md Added changelog entry for version 0.1.2 documenting the change
docs/catalog/s3vectors.md Updated all example SQL statements to use the new import foreign schema syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@burmecia burmecia requested a review from imor November 19, 2025 07:44
@burmecia burmecia merged commit 8443e16 into main Nov 25, 2025
12 checks passed
@burmecia burmecia deleted the bo/chore/remove-bucket-name-option branch November 25, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants