use project.scripts instead of tool.poetry.scripts for entrypoints
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the change from poetry to pdm in supakeen#121, it appears that some build systems have trouble groking what scripts to install due to the use of the poetry-specific entrypoint configuration in pyproject.toml. This change updates the pyproject.toml to use the [PEP-621](https://www.python.org/dev/peps/pep-0621) specification for identifying console_scripts/entrypoints, and resolves the build issue on Fedora. From my testing, there is no impact for installations via e.g. `pip`, as these tools will understand PEP-621 entrypoint specifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change from poetry to pdm in #121, it appears that some build systems have trouble groking what scripts to install due to the use of the poetry-specific entrypoint configuration in pyproject.toml.
This change updates the pyproject.toml to use the
PEP-621 specification for identifying console_scripts/entrypoints, and resolves the build issue on Fedora. From my testing, there is no impact for installations via e.g.
pip, as these tools will understand PEP-621 entrypoint specifications.