Skip to content

Commit 5be4926

Browse files
authored
feat: remove no-eslintrc and simplify eslint conf (#5809)
- Remove --no-eslintrc to simplify the upgrade path to ESlint >= v9, because v9 defaults to aonther configuration file format. - Simplify the default ESlint configuration removing options that have been deprecated, or that are equal to the default ones. Close #5688
1 parent 57c8658 commit 5be4926

2 files changed

Lines changed: 6 additions & 39 deletions

File tree

‎TEMPLATES/.eslintrc.yml‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,51 +1,18 @@
11
---
2-
#############################
3-
#############################
4-
## JavaScript Linter rules ##
5-
#############################
6-
#############################
7-
8-
############
9-
# Env Vars #
10-
############
112
env:
123
browser: true
134
es6: true
145
jest: true
156

16-
###############
17-
# Global Vars #
18-
###############
19-
globals:
20-
Atomics: readonly
21-
SharedArrayBuffer: readonly
22-
237
ignorePatterns:
248
- "!.*"
259
- "**/node_modules/.*"
2610

27-
###############
28-
# Parser vars #
29-
###############
3011
parser: '@typescript-eslint/parser'
31-
parserOptions:
32-
ecmaVersion: 2018
33-
sourceType: module
3412

35-
###########
36-
# Plugins #
37-
###########
3813
plugins:
3914
- '@typescript-eslint'
4015

41-
#########
42-
# Rules #
43-
#########
44-
rules: { }
45-
46-
##############################
47-
# Overrides for JSON parsing #
48-
##############################
4916
overrides:
5017

5118
# JSON files

‎lib/functions/linterCommands.sh‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ LINTER_COMMANDS_ARRAY_GOOGLE_JAVA_FORMAT=(java -jar /usr/bin/google-java-format
6161
LINTER_COMMANDS_ARRAY_GROOVY=(npm-groovy-lint -c "${GROOVY_LINTER_RULES}" --failon warning --no-insight)
6262
LINTER_COMMANDS_ARRAY_HTML=(htmlhint --config "${HTML_LINTER_RULES}")
6363
LINTER_COMMANDS_ARRAY_JAVA=(java -jar /usr/bin/checkstyle -c "${JAVA_LINTER_RULES}")
64-
LINTER_COMMANDS_ARRAY_JAVASCRIPT_ES=(eslint --no-eslintrc -c "${JAVASCRIPT_ES_LINTER_RULES}")
64+
LINTER_COMMANDS_ARRAY_JAVASCRIPT_ES=(eslint -c "${JAVASCRIPT_ES_LINTER_RULES}")
6565
LINTER_COMMANDS_ARRAY_JAVASCRIPT_STANDARD=(standard "${JAVASCRIPT_STANDARD_LINTER_RULES}")
6666
LINTER_COMMANDS_ARRAY_JAVASCRIPT_PRETTIER=(prettier --check)
6767
LINTER_COMMANDS_ARRAY_JSCPD=(jscpd --config "${JSCPD_LINTER_RULES}")
68-
LINTER_COMMANDS_ARRAY_JSON=(eslint --no-eslintrc -c "${JAVASCRIPT_ES_LINTER_RULES}" --ext '.json')
69-
LINTER_COMMANDS_ARRAY_JSONC=(eslint --no-eslintrc -c "${JAVASCRIPT_ES_LINTER_RULES}" --ext '.json5,.jsonc')
70-
LINTER_COMMANDS_ARRAY_JSX=(eslint --no-eslintrc -c "${JSX_LINTER_RULES}")
68+
LINTER_COMMANDS_ARRAY_JSON=(eslint -c "${JAVASCRIPT_ES_LINTER_RULES}" --ext '.json')
69+
LINTER_COMMANDS_ARRAY_JSONC=(eslint -c "${JAVASCRIPT_ES_LINTER_RULES}" --ext '.json5,.jsonc')
70+
LINTER_COMMANDS_ARRAY_JSX=(eslint -c "${JSX_LINTER_RULES}")
7171
LINTER_COMMANDS_ARRAY_KOTLIN=(ktlint "{/}")
7272
LINTER_COMMANDS_ARRAY_KUBERNETES_KUBECONFORM=(kubeconform -strict)
7373
if [ "${KUBERNETES_KUBECONFORM_OPTIONS}" != "null" ] && [ -n "${KUBERNETES_KUBECONFORM_OPTIONS}" ]; then
@@ -126,8 +126,8 @@ LINTER_COMMANDS_ARRAY_TERRAFORM_FMT=(terraform fmt -check -diff)
126126
LINTER_COMMANDS_ARRAY_TERRAFORM_TFLINT=("TF_DATA_DIR=\"/tmp/.terraform-TERRAFORM_TFLINT-{//}\"" tflint -c "${TERRAFORM_TFLINT_LINTER_RULES}" "--filter=\"{/}\"")
127127
LINTER_COMMANDS_ARRAY_TERRAFORM_TERRASCAN=(terrascan scan -i terraform -t all -c "${TERRAFORM_TERRASCAN_LINTER_RULES}" -f)
128128
LINTER_COMMANDS_ARRAY_TERRAGRUNT=(terragrunt hclfmt --terragrunt-check --terragrunt-log-level error --terragrunt-hclfmt-file)
129-
LINTER_COMMANDS_ARRAY_TSX=(eslint --no-eslintrc -c "${TSX_LINTER_RULES}")
130-
LINTER_COMMANDS_ARRAY_TYPESCRIPT_ES=(eslint --no-eslintrc -c "${TYPESCRIPT_ES_LINTER_RULES}")
129+
LINTER_COMMANDS_ARRAY_TSX=(eslint -c "${TSX_LINTER_RULES}")
130+
LINTER_COMMANDS_ARRAY_TYPESCRIPT_ES=(eslint -c "${TYPESCRIPT_ES_LINTER_RULES}")
131131
LINTER_COMMANDS_ARRAY_TYPESCRIPT_STANDARD=(ts-standard --parser @typescript-eslint/parser --plugin @typescript-eslint/eslint-plugin --project "${TYPESCRIPT_STANDARD_TSCONFIG_FILE}")
132132
LINTER_COMMANDS_ARRAY_TYPESCRIPT_PRETTIER=(prettier --check)
133133
LINTER_COMMANDS_ARRAY_XML=(xmllint)

0 commit comments

Comments
 (0)