Skip to content

feat: remove no-eslintrc and simplify eslint conf - #5809

Merged
ferrarimarco merged 1 commit into
mainfrom
no-eslintrc
Jul 11, 2024
Merged

ferrarimarco merged 1 commit into
mainfrom
no-eslintrc

Conversation

@ferrarimarco

@ferrarimarco ferrarimarco commented Jul 1, 2024 •

Copy link
Copy Markdown
Collaborator

Proposed changes

  • Remove --no-eslintrc from ESlint commands to simplify the upgrade path to ESlint >= v9, because v9 defaults to another configuration file format.
  • Simplify the default ESlint configuration removing options that have been deprecated, or that are equal to the default ones.

Close #5688

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels Jul 1, 2024
@ferrarimarco ferrarimarco added this to the 6.8.0 milestone Jul 1, 2024
@ferrarimarco ferrarimarco self-assigned this Jul 1, 2024
- Remove --no-eslintrc to simplify the upgrade path to ESlint >= v9,
  because v9 defaults to aonther configuration file format.
- Simplify the default ESlint configuration removing options that have
  been deprecated, or that are equal to the default ones.

Close #5688
@ferrarimarco
ferrarimarco merged commit 5be4926 into main Jul 11, 2024
@ferrarimarco
ferrarimarco deleted the no-eslintrc branch July 11, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--no-eslintrc flag does not work anymore without setting ESLINT_USE_FLAT_CONFIG=false for ESlint

2 participants