Skip to content

chore: fix docker build warnings - #5862

Merged
ferrarimarco merged 1 commit into
super-linter:mainfrom
harryzcy:docker-warning
Jul 9, 2024
Merged

ferrarimarco merged 1 commit into
super-linter:mainfrom
harryzcy:docker-warning

Conversation

@harryzcy

@harryzcy harryzcy commented Jul 9, 2024 •

Copy link
Copy Markdown
Contributor

Proposed changes

Fix the following two warnings:

  • FromAsCasing: 'as' and 'FROM' keywords' casing do not match
  • LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

@ferrarimarco

ferrarimarco commented Jul 9, 2024 •

Copy link
Copy Markdown
Collaborator

Thanks for this PR!

There's also a --check option. It might be interesting to add it as a test. We can do that in another PR.

@ferrarimarco ferrarimarco mentioned this pull request Jul 9, 2024
10 tasks done
@ferrarimarco ferrarimarco self-assigned this Jul 9, 2024
@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Jul 9, 2024
@ferrarimarco ferrarimarco added this to the 6.8.0 milestone Jul 9, 2024
@ferrarimarco
ferrarimarco added this pull request to the merge queue Jul 9, 2024
Merged via the queue into super-linter:main with commit fc094cc Jul 9, 2024
@harryzcy
harryzcy deleted the docker-warning branch July 10, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants