Skip to content

feat: enable dotenv-linter for slim images - #5868

Merged
ferrarimarco merged 1 commit into
mainfrom
move-env-linter-to-slim
Jul 10, 2024
Merged

ferrarimarco merged 1 commit into
mainfrom
move-env-linter-to-slim

Conversation

@ferrarimarco

@ferrarimarco ferrarimarco commented Jul 10, 2024 •

Copy link
Copy Markdown
Collaborator

Proposed changes

Set up dotenv-linter for the slim image, and not only for the standard image because it doesn't have dependencies on the Rust SDK, and weights less than 10MB:

4.98MB 6 minutes ago COPY /dotenv-linter /usr/bin/ # buildkit

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels Jul 10, 2024
@ferrarimarco ferrarimarco self-assigned this Jul 10, 2024
@ferrarimarco
ferrarimarco force-pushed the move-env-linter-to-slim branch from 601bf53 to fd0f1d0 Compare July 10, 2024 11:36
@ferrarimarco ferrarimarco added this to the 6.8.0 milestone Jul 10, 2024
@ferrarimarco
ferrarimarco force-pushed the move-env-linter-to-slim branch from fd0f1d0 to 587a465 Compare July 10, 2024 12:46
Set up dotenv-linter for the slim image, and not only for the standard
image because it doesn't have dependencies on the Rust SDK, and weights
less than 10MB.
@ferrarimarco
ferrarimarco force-pushed the move-env-linter-to-slim branch from 587a465 to ad70e13 Compare July 10, 2024 13:01
@ferrarimarco
ferrarimarco merged commit c770a8d into main Jul 10, 2024
@ferrarimarco
ferrarimarco deleted the move-env-linter-to-slim branch July 10, 2024 13:50
ferrarimarco added a commit that referenced this pull request Jul 10, 2024
Don't remove ENV from the list of linters to run in the slim image.
Follow up to #5868
ferrarimarco added a commit that referenced this pull request Jul 10, 2024
Don't remove ENV from the list of linters to run in the slim image.
Follow up to #5868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant