Skip to content

ci: enable dev-dependencies docker build checks - #5871

Merged
ferrarimarco merged 1 commit into
mainfrom
check-dev-container
Jul 11, 2024
Merged

ferrarimarco merged 1 commit into
mainfrom
check-dev-container

Conversation

@ferrarimarco

@ferrarimarco ferrarimarco commented Jul 10, 2024 •

Copy link
Copy Markdown
Collaborator

Proposed changes

  • Run Docker build checks when building the dev-dependencies container
    image and when running the test target.
  • Run Docker build checks when building the Super-linter container, and
    not just when running the test target.
  • Use the correct variable when setting the dev-dependencies container
    user.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Jul 10, 2024
@ferrarimarco ferrarimarco added this to the 6.8.0 milestone Jul 10, 2024
@ferrarimarco ferrarimarco self-assigned this Jul 10, 2024
- Run Docker build checks when building the dev-dependencies container
  image and when running the test target.
- Run Docker build checks when building the Super-linter container, and
  not just when running the test target.
- Use the correct variable when setting the dev-dependencies container
  user.
@ferrarimarco
ferrarimarco force-pushed the check-dev-container branch from 544d335 to a6794cc Compare July 10, 2024 15:11
@ferrarimarco
ferrarimarco merged commit 12da497 into main Jul 11, 2024
@ferrarimarco
ferrarimarco deleted the check-dev-container branch July 11, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant