Repository navigation
fix: update pylint to ignore import-errors - #5927
Merged
ferrarimarco merged 1 commit intoJul 31, 2024
Merged
Conversation
Shop-kins
marked this pull request as ready for review
July 25, 2024 12:50
Shop-kins
requested review from
Hanse00,
ferrarimarco and
zkoppert
as code owners
July 25, 2024 12:50
ferrarimarco
added
bug
ferrarimarco
requested changes
Jul 25, 2024
ferrarimarco
left a comment
ferrarimarco
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this PR. A small thing to check.
Shop-kins
force-pushed
the
fix/disable-import-error
branch
from
July 25, 2024 13:04
9073c94 to
09bcadb
Compare
Collaborator
|
Thanks! |
Collaborator
|
Thanks for the update. The builds are failing because:
Can you please fix the commit message? Meanwhile, I'll check if we need that second configuration file or not. |
10 tasks done
Collaborator
|
By rebasing on top of the latest |
Shop-kins
force-pushed
the
fix/disable-import-error
branch
5 times, most recently
from
July 29, 2024 08:48
7e3d9bb to
cb9be54
Compare
Contributor
Author
Have rebased and removed the capitals! |
Collaborator
|
Thanks! |
ferrarimarco
changed the title
ferrarimarco
requested changes
Jul 30, 2024
ferrarimarco
left a comment
ferrarimarco
left a comment
Collaborator
There was a problem hiding this comment.
A minor thing to fix, and we shall be good to go!
Thanks for this work :)
-re-instates previous super-linter pylint functionality -ignoring import errors is desired as super-linter does not support installing dependencies as it runs -creates a new test case file for confirming import-errors are disabled this consists of a 3rd party import and a basic usage
ferrarimarco
force-pushed
the
fix/disable-import-error
branch
from
July 31, 2024 07:00
cb9be54 to
5c0eb8d
Compare
ferrarimarco
approved these changes
Jul 31, 2024
ferrarimarco
enabled auto-merge
July 31, 2024 07:26
ferrarimarco
disabled auto-merge
July 31, 2024 07:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds back import-error to the pylint disable rules that was removed as of: #5252
Fix #5926
Proposed changes
update .python-lint to include
disable=import-errorAlso adds a new test case for import errors
Readiness checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks
Fix #ISSUE_NUMBERorClose #ISSUE_NUMBERtext to the description of the pull request.Super-linter maintainer tasks
breakingif this change breaks compatibility with the previous released version.automation,bug,documentation,enhancement,infrastructure.