Skip to content

fix: avoid duplicated content in summary - #5939

Merged
ferrarimarco merged 1 commit into
mainfrom
output-module
Jul 30, 2024
Merged

ferrarimarco merged 1 commit into
mainfrom
output-module

Conversation

@ferrarimarco

@ferrarimarco ferrarimarco commented Jul 29, 2024 •

Copy link
Copy Markdown
Collaborator

Proposed changes

  • Remove the previous summary file if present to avoid showing stale contents from old summaries.
  • Extract the logic to write summary heading and lines to dedicated functions in output.sh to make it easier adding new formats in the future.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

- Remove the previous summary file is present to avoid showing stale
  contents from old summaries.
- Extract the logic to write summary heading and lines to dedicated
  functions in output.sh to make it easier adding new formats in the
  future.
@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Jul 29, 2024
@ferrarimarco ferrarimarco added this to the 6.8.0 milestone Jul 29, 2024
@ferrarimarco ferrarimarco self-assigned this Jul 29, 2024
@ferrarimarco
ferrarimarco merged commit ef57e13 into main Jul 30, 2024
@ferrarimarco
ferrarimarco deleted the output-module branch July 30, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant