Skip to content

feat: customize phpstan config file name - #5940

Merged
ferrarimarco merged 1 commit into
super-linter:mainfrom
shabbir-genetech:phpstan_config
Jul 30, 2024
Merged

ferrarimarco merged 1 commit into
super-linter:mainfrom
shabbir-genetech:phpstan_config

Conversation

@shabbir-genetech

@shabbir-genetech shabbir-genetech commented Jul 30, 2024 •

Copy link
Copy Markdown
Contributor

Proposed changes

Add ability to configure PHPStan via PHP_PHPSTAN_CONFIG_FILE.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches with the version that release-please proposes.

@ferrarimarco ferrarimarco self-assigned this Jul 30, 2024
@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels Jul 30, 2024
@ferrarimarco ferrarimarco added this to the 6.8.0 milestone Jul 30, 2024

@ferrarimarco ferrarimarco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I think we just need to adjust the commit message, and we shall be good to go. Something like:

feat: customize phpstan config file name

@ferrarimarco
ferrarimarco enabled auto-merge July 30, 2024 14:22
@ferrarimarco ferrarimarco changed the title Add ability to configure PHPStan via PHP_PHPSTAN_CONFIG_FILE. feat: customize phpstan config file name Jul 30, 2024
@ferrarimarco
ferrarimarco added this pull request to the merge queue Jul 30, 2024
Merged via the queue into super-linter:main with commit 20c4df5 Jul 30, 2024
@shabbir-genetech

Copy link
Copy Markdown
Contributor Author

@ferrarimarco Can you advise on when the next release might be released which will include this change? Is there a way to use it right now in GitHub actions? I tried uses: super-linter/super-linter@latest but that still seems to pull ghcr.io/super-linter/super-linter:v6.7.0 .

@ferrarimarco

Copy link
Copy Markdown
Collaborator

Hi @shabbir-genetech !

I think we can release one over the course of this week, since it's long due.

uses: super-linter/super-linter@latest but that still seems to pull ghcr.io/super-linter/super-linter:v6.7.0

This is expected. We currently point the latest action to the most recently released version, not to the latest container image because that might be less stable than a released version.

As a workaround, you can still name your PHPStan rules file as phpstan.neon. Super-linter will pick it up.

Thanks for your work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants