From 329f4e592d718381a8517c878e59e431d52c792d Mon Sep 17 00:00:00 2001 From: Narek Mkhitaryan Date: Fri, 24 Mar 2023 11:38:45 +0400 Subject: [PATCH 1/2] fix filehandler logger --- src/superannotate/lib/core/__init__.py | 27 ++++++++++++-------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/src/superannotate/lib/core/__init__.py b/src/superannotate/lib/core/__init__.py index fe97dabf9..3d63eaf08 100644 --- a/src/superannotate/lib/core/__init__.py +++ b/src/superannotate/lib/core/__init__.py @@ -16,7 +16,6 @@ from lib.core.enums import UploadState from lib.core.enums import UserRole - CONFIG = Config() BACKEND_URL = "https://api.superannotate.com" HOME_PATH = expanduser("~/.superannotate") @@ -33,7 +32,6 @@ def setup_logging(level=DEFAULT_LOGGING_LEVEL, file_path=LOG_FILE_LOCATION): - logger = logging.getLogger("sa") for handler in logger.handlers[:]: # remove all old handlers logger.removeHandler(handler) @@ -46,19 +44,18 @@ def setup_logging(level=DEFAULT_LOGGING_LEVEL, file_path=LOG_FILE_LOCATION): try: os.makedirs(file_path, exist_ok=True) log_file_path = os.path.join(file_path, "sa.log") - open(log_file_path, "w").close() - if os.access(log_file_path, os.W_OK): - file_handler = RotatingFileHandler( - log_file_path, - maxBytes=5 * 1024 * 1024, - backupCount=5, - mode="a", - ) - file_formatter = Formatter( - "SA-PYTHON-SDK - %(levelname)s - %(asctime)s - %(message)s" - ) - file_handler.setFormatter(file_formatter) - logger.addHandler(file_handler) + file_handler = RotatingFileHandler( + log_file_path, + maxBytes=5 * 1024 * 1024, + backupCount=5, + mode="a", + ) + file_formatter = Formatter( + "SA-PYTHON-SDK - %(levelname)s - %(asctime)s - %(message)s" + ) + file_handler.setFormatter(file_formatter) + logger.addHandler(file_handler) + except OSError as e: logger.debug(e) From 25fa242bac30c4e71fee6583b0490b13c9e651de Mon Sep 17 00:00:00 2001 From: Narek Mkhitaryan Date: Fri, 24 Mar 2023 18:54:19 +0400 Subject: [PATCH 2/2] fix logs duplicating --- src/superannotate/lib/core/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/superannotate/lib/core/__init__.py b/src/superannotate/lib/core/__init__.py index 3d63eaf08..3354cf264 100644 --- a/src/superannotate/lib/core/__init__.py +++ b/src/superannotate/lib/core/__init__.py @@ -35,7 +35,7 @@ def setup_logging(level=DEFAULT_LOGGING_LEVEL, file_path=LOG_FILE_LOCATION): logger = logging.getLogger("sa") for handler in logger.handlers[:]: # remove all old handlers logger.removeHandler(handler) - logger.propagate = True + logger.propagate = False logger.setLevel(level) stream_handler = logging.StreamHandler() formatter = Formatter("SA-PYTHON-SDK - %(levelname)s - %(message)s")