Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add algorithm repo #122

Merged
merged 31 commits into from Nov 26, 2019
Merged

Feature/add algorithm repo #122

merged 31 commits into from Nov 26, 2019

Conversation

@peacemoon
Copy link
Collaborator

peacemoon commented Nov 24, 2019

No description provided.

@peacemoon

This comment has been minimized.

Copy link
Collaborator Author

peacemoon commented Nov 24, 2019

Warnings
⚠️

You have created SwiftCommunity/Features/Algorithm/Sources/Base/UI/Scenes/Dashboard/ViewModel/ContentTableViewModel.swift but there is no test ContentTableViewModelTests.swift found.

⚠️

You have created SwiftCommunity/Features/Algorithm/Sources/Base/UI/Scenes/Dashboard/ViewModel/ContentViewModel.swift but there is no test ContentViewModelTests.swift found.

⚠️

You have created SwiftCommunity/Core/Sources/Base/Engine/Domain/Services/Git/ConferencesGitService.swift but there is no test ConferencesGitServiceTests.swift found.

⚠️

You have created SwiftCommunity/Features/Algorithm/Sources/Base/Engine/DomainLogic/AlgorithmService.swift but there is no test AlgorithmServiceTests.swift found.

SwiftLint found issues

Severity File Reason
Warning AppDelegate.swift:16 Lines should not have trailing whitespace. (trailing_whitespace)
Warning FeatureAComponent.swift:62 TODOs should be resolved (this will create a new Feature...). (todo)
Warning FeatureBComponent.swift:17 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
Warning FeatureDComponent.swift:28 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)

Generated by 🚫 Danger Swift against cf4099d

@peacemoon peacemoon force-pushed the feature/add_algorithm_repo branch from 259adf1 to aa9e6d2 Nov 24, 2019
peacemoon added 10 commits Nov 25, 2019
@peacemoon

This comment has been minimized.

Copy link
Collaborator Author

peacemoon commented Nov 26, 2019

Warnings
⚠️

You have created SwiftCommunity/Features/Algorithm/Sources/Base/UI/Scenes/Dashboard/ViewModel/ContentTableViewModel.swift but there is no test ContentTableViewModelTests.swift found.

⚠️

You have created SwiftCommunity/Features/Algorithm/Sources/Base/UI/Scenes/Dashboard/ViewModel/ContentViewModel.swift but there is no test ContentViewModelTests.swift found.

⚠️

You have created SwiftCommunity/Core/Sources/Base/Engine/Domain/Services/Git/ConferencesGitService.swift but there is no test ConferencesGitServiceTests.swift found.

⚠️

You have created SwiftCommunity/Features/Algorithm/Sources/Base/Engine/DomainLogic/AlgorithmService.swift but there is no test AlgorithmServiceTests.swift found.

SwiftLint found issues

Severity File Reason
Warning AppDelegate.swift:16 Lines should not have trailing whitespace. (trailing_whitespace)
Warning FeatureAComponent.swift:62 TODOs should be resolved (this will create a new Feature...). (todo)
Warning FeatureBComponent.swift:17 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
Warning FeatureDComponent.swift:28 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)

Generated by 🚫 Danger Swift against fdb1f9c

@peacemoon

This comment has been minimized.

Copy link
Collaborator Author

peacemoon commented Nov 26, 2019

Fails
🚫 Failed to get the coverage - Error: Could not find the xcresult file

Generated by 🚫 Danger Swift against 3cac307

peacemoon added 2 commits Nov 26, 2019
@peacemoon peacemoon merged commit 0a2475c into master Nov 26, 2019
0 of 2 checks passed
0 of 2 checks passed
UnitTest (platform=iOS Simulator,OS=13.1,name=iPhone 11) UnitTest (platform=iOS Simulator,OS=13.1,name=iPhone 11)
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@peacemoon peacemoon deleted the feature/add_algorithm_repo branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.